You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed some very fishy code when I looked inside the /editor/find folder thanks to #32113
the /editor/ folder should not take a dependency on the workbench. We don't have a linter warning / pre-commit hook for it, but using the CSS class name .monaco-workbench in the /editor/ folder indicates that something is wrong or badly layered.
some similar-looking CSS appears in simpleFindWidget.css and in findWidget.css. A decision should be done if these are two separate widgets or a single widget used in different ways. If these are two different widgets, then the workbench specific widget should move to the /workbench/ folder, together with its CSS and images and all. If you'd want to reuse some code, then that's also fine, but then there should be no exact CSS rules that end up e.g. inlining the same image in multiple places in workbench.main.css. As it appears right now, we are somewhere in the middle.
The text was updated successfully, but these errors were encountered:
I've noticed some very fishy code when I looked inside the
/editor/find
folder thanks to #32113the
/editor/
folder should not take a dependency on the workbench. We don't have a linter warning / pre-commit hook for it, but using the CSS class name.monaco-workbench
in the/editor/
folder indicates that something is wrong or badly layered.some similar-looking CSS appears in
simpleFindWidget.css
and infindWidget.css
. A decision should be done if these are two separate widgets or a single widget used in different ways. If these are two different widgets, then the workbench specific widget should move to the/workbench/
folder, together with its CSS and images and all. If you'd want to reuse some code, then that's also fine, but then there should be no exact CSS rules that end up e.g. inlining the same image in multiple places inworkbench.main.css
. As it appears right now, we are somewhere in the middle.The text was updated successfully, but these errors were encountered: