Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insiders orange icon / logo mis-sized #33090

Closed
alexcnichols opened this issue Aug 24, 2017 · 16 comments
Closed

Insiders orange icon / logo mis-sized #33090

alexcnichols opened this issue Aug 24, 2017 · 16 comments
Assignees
Labels
extensions Issues concerning extensions icon-brand VS Code brand icon issues
Milestone

Comments

@alexcnichols
Copy link

  • VSCode Version: Code - Insiders 1.16.0-insider (936fc3f, 2017-08-24T08:26:28.878Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
team ms- 1.122.0

The new orange icon / logo for Insiders is cool but mis-sized in the installer, taskbar, and application window.

image


Steps to Reproduce:

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added extensions Issues concerning extensions insiders labels Aug 24, 2017
@alexcnichols
Copy link
Author

Also, the logo on the welcome page is still the green one.

image

@chrisdias chrisdias added the icon-brand VS Code brand icon issues label Aug 24, 2017
@chrisdias
Copy link
Member

The Setup issue is a dupe of #33080.

@alexcnichols When you mention the taskbar and application window, are you still referring to setup, or the product itself? If you can post images, that would be helpful.

I opened #33095 for the Welcome page.

@alexcnichols
Copy link
Author

@chrisdias Product itself.

image

@chrisdias
Copy link
Member

Taskbar looks consistent with VS, and it looks like our title bar is not as tall (the VS title bar is custom drawn), meaning the icon will be scaled down for VS Code, so I'm not sure if we can do anything there @bpasero ?

image

@bpasero bpasero self-assigned this Aug 24, 2017
@bpasero bpasero added this to the August 2017 milestone Aug 24, 2017
@alexcnichols
Copy link
Author

The leftmost 1 or 2 pixels is clipped off in the new Insiders icon. Yeah, I can see how the title bar leaves less real estate.

@bpasero
Copy link
Member

bpasero commented Aug 24, 2017

@joaomoreno can we use any other format in the installer than BMP or is that a limitation we cannot lift?

@chrisdias title bar is not under our control until we approach implementing a custom title and menu (#29024)

@bpasero
Copy link
Member

bpasero commented Aug 24, 2017

To be fair, our current installer is also not a beauty:

image

@bpasero
Copy link
Member

bpasero commented Aug 24, 2017

Icon looks ok to me in the title bar on my Win10:

image

@joaomoreno
Copy link
Member

@bpasero AFAIK it needs to be a bitmap: http://www.jrsoftware.org/ishelp/topic_setup_wizardimagefile.htm

@alexcnichols
Copy link
Author

The empty page has the problem too.

image

@qpegg
Copy link

qpegg commented Aug 24, 2017

Is there any possibility that he point out the new icon is not the infinity symbol?

@chrisdias
Copy link
Member

@qpegg you may be right... @alexcnichols the fact that there is no vertical line on the left is intentional... please see #6607 (comment).

@alexcnichols
Copy link
Author

My mistake. Sorry for the confusion. Closing as-designed.

@qpegg
Copy link

qpegg commented Aug 25, 2017

@chrisdias

#33080 (comment), like the visual studio

@LucasArcega
Copy link

How can i go back to blue?

@LucasArcega
Copy link

How can i go back to the blue logo one?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions icon-brand VS Code brand icon issues
Projects
None yet
Development

No branches or pull requests

6 participants