Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal processes exit too eagerly if window close is canceled #31988

Closed
delicb opened this issue Aug 3, 2017 · 1 comment
Closed

Terminal processes exit too eagerly if window close is canceled #31988

delicb opened this issue Aug 3, 2017 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
January 2018

Comments

@delicb
Copy link

delicb commented Aug 3, 2017 •
edited
Loading

  • VSCode Version: 1.14.2 (cb82feb)
  • OS Version: macOS Siera (10.12.6)

Steps to Reproduce:

  1. Open VSCode and open integrated terminal
  2. Make changes to some file
  3. Invoke VSCode shutdown (e.g. via clicking x button)
  4. When prompted with question if you want to save file content click Cancel
  5. I expected everything to continue working, but terminal was terminated
  6. After closing it and opening it again it did start and was functional, but selection of text in terminal is not possible.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Aug 3, 2017
@Tyriar
Copy link
Member

Tyriar commented Aug 21, 2017

I believe the selection issue is fixed in latest.

As for closing terminals this seems like a bug.

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Aug 21, 2017
@Tyriar Tyriar added this to the Backlog milestone Aug 21, 2017
@Tyriar Tyriar changed the title Terminal quits if app termination is started but not finished Terminal processes exit too eagerly if window close is canceled Dec 23, 2017
@Tyriar Tyriar modified the milestones: Backlog, December 2017/January 2018 Dec 23, 2017
@Tyriar Tyriar closed this as completed in ff9ad43 Dec 23, 2017
@roblourens roblourens added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
3 participants
@delicb @roblourens @Tyriar