Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode doesn't launch at all from the terminal (Ubuntu 15) after v0.10.8 #3131

Closed
hashhar opened this issue Feb 18, 2016 · 12 comments
Closed
Assignees

Comments

@hashhar
Copy link
Contributor

hashhar commented Feb 18, 2016

screenshot from 2016-02-19 00-03-15

All the system information is available in the image.

@Tyriar
Copy link
Member

Tyriar commented Feb 18, 2016

@hashhar I'm assuming code is a symlink to Code, as in https://github.com/hashhar/vscode-universal-installer/blob/master/install.py? I haven't had any issues so far using Ubuntu/Compiz 15.10 and plain Debian 8.3.0. Did this just start happening with a newer version? How do you normally launch code on Linux?

Launching using sudo is a known issue #3068

@hashhar
Copy link
Contributor Author

hashhar commented Feb 19, 2016

/usr/local/bin/code is a symlink to /opt/VSCode/Code.
It started with 0.10.8. But I had also uninstalled some packages before that so it could be that. Does VSCode have any external dependencies?

The absurd part is that clicking on the launcher I made ( see https://github.com/hashhar/vscode-universal-installer/blob/master/VSCode.desktop) launches it as it should. And both of them are using the same executable symlink.

I'll try reproducing this on a VM.

@hashhar
Copy link
Contributor Author

hashhar commented Feb 19, 2016

I can't reproduce this on other systems. Seems to be something wrong with my machine. My own machine can now not run any of the older releases too from the terminal.

@hashhar hashhar closed this as completed Feb 19, 2016
@Tyriar
Copy link
Member

Tyriar commented Feb 19, 2016

@hashhar ok, if you end up figuring it out please ping this issue as vscode may be able to warn/advise about the situation.

@hashhar
Copy link
Contributor Author

hashhar commented Feb 21, 2016

@Tyriar Some more context. I cannot even start Code even if I build it locally.

This is what happens.

screenshot from 2016-02-21 17-01-41

@hashhar hashhar reopened this Feb 21, 2016
@hashhar
Copy link
Contributor Author

hashhar commented Feb 21, 2016

It only happens when I try to start it from the shell. Double clicking on the symlink as well as the executable launches it without problem. I even tried clearing ~/.config/Code.

Using a different Window Manager also didn't help.
I'll now try using a different shell.

@hashhar
Copy link
Contributor Author

hashhar commented Feb 21, 2016

Yup. It's the SHELL. Using zsh also gave the error. But as soon as I set SHELL=/bin/zsh, it started.

@Tyriar Maybe add this to the docs or FAQ. I'll try narrowing down the source of this. I was able to reproduce it on another install. This happens after some system updates.

@hashhar
Copy link
Contributor Author

hashhar commented Feb 21, 2016

Works for every possible value of SHELL. It just doesn't work when SHELL=/bin/bash. /bin/sh works. insert random string here also works.

This is a workaround but I would like a fix.

This seems relevant. https://github.com/Microsoft/vscode/blob/master/src/vs/base/node/env.ts#L22
Changing that line to a hardcoded value allowed me to run it. I set it to '/bin/sh'.

@Tyriar Tyriar changed the title VSCode doesn't launch at all from the terminal (Ubuntu 15) after v0.10.8 VSCode doesn't launch on zsh Feb 21, 2016
@Tyriar Tyriar changed the title VSCode doesn't launch on zsh VSCode doesn't launch at all from the terminal (Ubuntu 15) after v0.10.8 Feb 21, 2016
@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2016

Interesting, I can run it just fine with bash as well as zsh.

@hashhar
Copy link
Contributor Author

hashhar commented Feb 21, 2016

It's not the terminal emulator. It's the shell that $SHELL is pointing to.

Try setting $SHELL to /bin/bash or /bin/sh.

@hashhar hashhar closed this as completed Feb 21, 2016
@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2016

It works when $SHELL is /bin/bash, /bin/sh and /bin/zsh.

@hashhar
Copy link
Contributor Author

hashhar commented Feb 21, 2016

Thanks. Consider this closed then. A workaround is known atleast.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants