Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support External Files Provided by TS Plugin #30411

Closed
mjbvz opened this issue Jul 11, 2017 · 4 comments
Closed

Support External Files Provided by TS Plugin #30411

mjbvz opened this issue Jul 11, 2017 · 4 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code plan-item VS Code - planned item for upcoming typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Backlog

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 11, 2017 •
edited
Loading

Problem
Support the new external files option that TS plugins can provide: microsoft/TypeScript#15308

We currently allow TSServer plugin extensions to register themselves for custom language modes. The angular extension for example could register the angular plugin with support for the ng-html language. There were a few problems with the current implementation:

  1. We start automatically syncing all ng-html files with TSServer.
  2. If the angular plugin is not active, TS treats these ng-html files as TypeScript code

Potential Fix
On potential fix we discussed previously: add a plugin property on open requests. TypeScript would look at the plugin property and only start validating the file if has the corresponding plugin.
@mjbvz mjbvz added plan-item VS Code - planned item for upcoming typescript Typescript support issues labels Jul 11, 2017
@mjbvz mjbvz added this to the July 2017 milestone Jul 11, 2017
@mjbvz mjbvz self-assigned this Jul 11, 2017
@kieferrm kieferrm mentioned this issue Jul 11, 2017
Closed
39 tasks
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 12, 2017

Tracked upstream by microsoft/TypeScript#17151

@mjbvz mjbvz modified the milestones: August 2017, July 2017 Jul 24, 2017
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 24, 2017

Discussions and planning work done for July. Proposed API: microsoft/TypeScript#17151

Moving to August since we need an API change on the TS side to support this. This change would likely come with TS 2.5

@kieferrm kieferrm mentioned this issue Aug 9, 2017
Closed
53 tasks
@mjbvz mjbvz modified the milestones: Backlog, August 2017 Aug 28, 2017
@mjbvz
Copy link
Collaborator Author

mjbvz commented Aug 28, 2017

Moving out to at least TS 2.6

@mjbvz mjbvz added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 14, 2017
@mjbvz
Copy link
Collaborator Author

mjbvz commented Dec 15, 2018

Closing as out of date. Discussion of this feature is at microsoft/TypeScript#17151

@mjbvz mjbvz closed this as completed Dec 15, 2018
@mjbvz mjbvz added the *out-of-scope Posted issue is not in scope of VS Code label Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code plan-item VS Code - planned item for upcoming typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@mjbvz