-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title Bar should adapt to theme #29997
Comments
Is that even possible on windows? |
Indeed it is, the fastest way might be to use a library like (or actually) the following: The titlebar could use the background and text colour of the editor background. |
This is a great idea, and that mockup looks lovely. I wonder what it would mean for branding, though? I'd love to highlight the icon issue too from discussion in #882 . It becomes much more pressing when the title bar changes for all users (so far it only get weird when people manually enable accent colours). |
Infect, Electron provide APIs to create frameless window. Frameless Window. So we can draw our own title bar to modify it. |
@Hypnoes correct, adding the frameless option to /src/vs/code/electron-main/window.ts Things that need to implement are:
I'm also pretty sure this removes the error where I would like to tackle the issue myself, but tbh I've got not enough time left for at least 2 months :P |
For those who prefer windows and use vscode extensively, looking at a white title bar or a color that doesn't match your theme get's really annoying. Would love for this to be added. |
Will this issue get any love anytime soon? |
Agree with windows white titlebar and vscode don't match well together. Atom has a nice solution for this problem https://atom.io/packages/title-bar-replacer it would be nice if vs code team added this feature |
This feature has been added in a recent pull request: #39972 Someone tell me if I'm doing this wrong :) I just really love how well this works |
Well, the title bar in Windows/Linux can be customized to adapt to the theme, This is available as a preview feature in Version 1.25 (out now). Since, it is a preview feature it is not available by default, you need to enable it.
Change the color values as per your requirement. |
@pavittarx man... that was what I needed |
They have just recently added it to the backlog search for [Feature Request] Customizable Titlebar Buttons |
The intent is to make this the default behavior on Windows this milestone. |
@yknomeh Thanks, I just tried to help the ones who started this thread or the ones who may come in searching here. 😃 @pedzed This feature was pending from a long time, while the problem was that title bars on Windows & Linux was unable to produce a dark title bar, when using a dark theme. I guess, you know that already. The feature has been implemented recently, but it is still better than what it used to be. 😆 I guess, you should look out for some other issue, or create a new one. The purpose of this one is served, finally `title bar adapts to the theme`, |
Steps to Reproduce:
1.The title bar stays white even the theme is switched to dark
2.
The text was updated successfully, but these errors were encountered: