Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should TypeScript build task be a watch task? #29580

Closed
dbaeumer opened this issue Jun 27, 2017 · 3 comments
Closed

Should TypeScript build task be a watch task? #29580

dbaeumer opened this issue Jun 27, 2017 · 3 comments
Assignees
Labels
plan-item VS Code - planned item for upcoming typescript Typescript support issues
Milestone

Comments

@dbaeumer
Copy link
Member

Currently the TypeScript build task is a normal compile. We could consider using a watch task instead since this gives us compile one save. Downside is that tsc -watch doesn't work well with large projects.

@egamma do you have a opinion ?

@dbaeumer dbaeumer changed the title Should TypeScript build task be a watch task Should TypeScript build task be a watch task? Jun 27, 2017
@dbaeumer dbaeumer added the typescript Typescript support issues label Jun 27, 2017
@egamma
Copy link
Member

egamma commented Jun 28, 2017

@dbaeumer making tsc a watch task is appealing it basically corresponds 'compile on save'. Since tsconfig.json supports a compileOnSave attribute we could use this attribute to decide whether the task is a compile or a watch task.

@dbaeumer
Copy link
Member Author

@egamma I like that suggestion very much. I then propose that we look into this for June.

@jens1o
Copy link
Contributor

jens1o commented Jun 29, 2017

@dbaeumer Do you mean July or can we expect that cool thing very soon? :)

@mjbvz mjbvz added this to the July 2017 milestone Jul 14, 2017
@mjbvz mjbvz added the plan-item VS Code - planned item for upcoming label Jul 14, 2017
@mjbvz mjbvz closed this as completed in ed327d3 Jul 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plan-item VS Code - planned item for upcoming typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

4 participants