Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension packs broken when sideloading #28915

Closed
jack-guy opened this issue Jun 16, 2017 · 3 comments
Closed

Extension packs broken when sideloading #28915

jack-guy opened this issue Jun 16, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions
Milestone

Comments

@jack-guy
Copy link

  • VSCode Version: Code 1.13.1 (379d2ef, 2017-06-14T18:13:05.928Z)
  • OS Version: Darwin x64 16.6.0

Steps to Reproduce:

  1. Use yo code to create an extension pack
  2. Add an extension dependency (e.g. PeterJausovec.vscode-docker)
  3. Package as vsix (vsce) OR copy extension pack folder to .vscode/extensions/
  4. Dependencies are not installed, and the "dependency" tab for the extension never loads, returning this trace:
shell.ts:445 Cannot read property 'properties' of null: TypeError: Cannot read property 'properties' of null
    at e.loadCompatibleVersion (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:591617)
    at e.getAllDependencies (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:591442)
    at e.loadDependencies (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:2248684)
    at e.task (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:84759)
    at e.get (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:62707)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:89196
    at t.loadContents (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:95436)
    at t.openDependencies (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:89141)
    at t.onNavbarChange (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:87295)
    at e.invoke (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:25074)
e.onUnexpectedError @ shell.ts:445
(anonymous) @ shell.ts:405
e.onUnexpectedError @ errors.ts:68
o @ errors.ts:88
e.invoke @ callbackList.ts:65
e.fire @ event.ts:123
e._update @ extensionEditor.ts:104
i @ extensionEditor.ts:82
e.run @ actions.ts:208
t.runAction @ actions.ts:237
t.run @ actions.ts:229
t.onClick @ actionbar.ts:152
(anonymous) @ actionbar.ts:132
@ramya-rao-a ramya-rao-a added the extensions Issues concerning extensions label Jun 17, 2017
@sandy081
Copy link
Member

@Harangue Extension packs are supported for extension which are in market place only. For those local extensions installed through .vsix, we are not showing dependencies / packs. #15477 Tracks this.

Will see why there is an exception.

@sandy081 sandy081 added this to the June 2017 milestone Jun 19, 2017
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jun 19, 2017
@sandy081 sandy081 modified the milestones: July 2017, June 2017 Jun 28, 2017
@sandy081
Copy link
Member

Related to #15477

@sandy081 sandy081 modified the milestones: August 2017, July 2017 Jul 25, 2017
@sandy081 sandy081 modified the milestones: Backlog, August 2017 Aug 22, 2017
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 22, 2017
@vscodebot
Copy link

vscodebot bot commented Nov 22, 2017

This issue has been closed because it is already tracked by another issue. See also our GitHub issues to search for existing issues and our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Nov 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

3 participants