Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a command to close all unchanged files #25667

Closed
soneymathew opened this issue Apr 29, 2017 · 7 comments
Closed

Provide a command to close all unchanged files #25667

soneymathew opened this issue Apr 29, 2017 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@soneymathew
Copy link
Contributor

soneymathew commented Apr 29, 2017

  • VSCode Version: all
  • OS Version: all

At work I use this editor heavily and sometimes end up in a situation where lots of editor are open.
It will be great if there is an option to close all unchanged files quickly.
Happy to raise a pull request for this as well !

  • Editor Action Support for Closing Unmodified files in a group from
    1. Explorer Open Editor's context menu
      closeviaexplorercontextmenu

    2. Editor Tab context menu
      closeviaeditortabcontextmenu

    3. Command Palette
      closeviacommandpalette

@kieferrm kieferrm added the feature-request Request for new features or functionality label May 1, 2017
@bpasero bpasero changed the title [Feature request] Option to close all unchanged files Provide a command to close all unchanged files May 2, 2017
@bpasero bpasero added the *extension-candidate Issue identified as good extension implementation label May 14, 2017
@bpasero
Copy link
Member

bpasero commented May 14, 2017

Imho this command should be provided as an extension.

@soneymathew
Copy link
Contributor Author

soneymathew commented May 14, 2017

@bpasero Imho I felt the other way round based on other editors I have used since this is a very common feature that qualified to be part of the core editor.

Atom
image

IntelliJ Idea
image

@bpasero
Copy link
Member

bpasero commented May 14, 2017

@soneymathew still, being out for 2 years and not having anyone complain about this potentially missing feature bothers me. I am not questioning its usefulness but I want this to be an extension if possible.

@soneymathew
Copy link
Contributor Author

Thanks for the guidance @bpasero , I am using vscode since less than a year and really miss this feature especially while exploring large code bases, while tracing code flows. The lighter the editor the more tabs I will have open until I narrow down the search to what I am looking for.

I spoke to a couple of users and got mixed reactions, so I think you have a good point there.
I will investigate if the extensions approach is performant enough to cater to this need when I get time away from work, probably a weekend. Till then I am happy using my fork for my daily usage ;)

Meanwhile would you consider keeping this issue open to see if any other users have a different point of view ?

@bpasero
Copy link
Member

bpasero commented May 15, 2017

@soneymathew sure we keep this open and we can also leave your PR open for now. Please give the extension model a try and see if there is something missing.

@bpasero bpasero removed the *extension-candidate Issue identified as good extension implementation label Jun 15, 2017
@bpasero bpasero self-assigned this Jun 15, 2017
@bpasero bpasero modified the milestones: July 2017, June 2017 Jun 15, 2017
@bpasero
Copy link
Member

bpasero commented Jun 15, 2017

Merged via #25692

@bpasero bpasero closed this as completed Jun 15, 2017
@bpasero bpasero added the verification-needed Verification of issue is requested label Jun 22, 2017
@bpasero
Copy link
Member

bpasero commented Jun 22, 2017

Verification
Verify the new "Close Unmodified" action works as expected from the various places where you can invoke it (commands palette, right click on a tab, open editors view).

@isidorn isidorn added the verified Verification succeeded label Jun 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants