Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic QuickPickItem items #25140

Closed
joaomoreno opened this issue Apr 21, 2017 · 4 comments
Closed

Support dynamic QuickPickItem items #25140

joaomoreno opened this issue Apr 21, 2017 · 4 comments
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Milestone

Comments

@joaomoreno
Copy link
Member

In order to implement #21439, it would be great to have a QuickPickItem which is never filtered out no matter what the user types. Additionally, it would be aware of what the user has typed when selected.

Proposal 1

export interface QuickPickItem {
  alwaysVisible?: boolean;
}

export interface QuickPickOptions {
  onDidPickItem?<T extends QuickPickItem>(item: T | string, input: string): any;
}

cc @jrieken

@joaomoreno joaomoreno added api feature-request Request for new features or functionality labels Apr 21, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Apr 21, 2017
@jrieken jrieken added the quick-pick Quick-pick widget issues label Apr 21, 2017
@jrieken
Copy link
Member

jrieken commented Apr 21, 2017

@jrieken jrieken closed this as completed Apr 21, 2017
@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 21, 2017
@joaomoreno
Copy link
Member Author

joaomoreno commented Apr 24, 2017

@jrieken Did you just flush my proposal down the toilet? I'm actually trying to do something here and starting a discussion.

@jrieken
Copy link
Member

jrieken commented Apr 24, 2017

No. As I have told you this request has been made already a few time, so I wasn't expecting you to create yet another duplicate but use an existing, long-standing issue. For instance these: #21372, #15659, and #11468

@joaomoreno
Copy link
Member Author

joaomoreno commented Apr 24, 2017

All those requests, aside from not fully addressing my issue, bring considerable conceptual changes to the quick pick API. The proposal in this issue is an incremental change.

But I understand if you want to stop any incremental changes in favour of a better thought-out APIv2.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

3 participants