Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM: Support only URI for iconPath #23648

Closed
joaomoreno opened this issue Mar 30, 2017 · 1 comment
Closed

SCM: Support only URI for iconPath #23648

joaomoreno opened this issue Mar 30, 2017 · 1 comment
Assignees
@joaomoreno
Labels
api scm General SCM compound issues
Milestone
March 2017

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Mar 30, 2017 •
edited
Loading

@jrieken

Tho what we could consider is to always use the Uri for the path. I know it's sort of legacy that the editor decoration api supports both and there was ambiguity if strings mean url or file path (see #12111 (comment))
@joaomoreno joaomoreno added api scm General SCM compound issues labels Mar 30, 2017
@joaomoreno joaomoreno added this to the March 2017 milestone Mar 30, 2017
@joaomoreno joaomoreno self-assigned this Mar 30, 2017
@joaomoreno joaomoreno mentioned this issue Mar 30, 2017
Closed
@joaomoreno
Copy link
Member Author

On a second thought, no. The whole API movement is surrounded by consistency. We already have two places where a user can provide an icon. It's always called iconPath and it's always Uri | string. So, keeping that up.

If we want to change it, we should change every instance, in a breaking matter.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
api scm General SCM compound issues
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
1 participant
@joaomoreno