Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Electron #23159

Closed
rongjiecomputer opened this issue Mar 24, 2017 · 4 comments
Closed

Upgrade Electron #23159

rongjiecomputer opened this issue Mar 24, 2017 · 4 comments
Assignees
@bpasero
Labels
plan-item VS Code - planned item for upcoming
Milestone
April 2017

Comments

@rongjiecomputer
Copy link

  • VSCode Version: 1.10.2
  • OS Version: Windows 10 (x64)

Steps to Reproduce:

  1. Open Developer Tools.
  2. Type navigator.userAgent

Result:
See WOW64 instead of Win64, Chrome is still 53 (old)

From https://github.com/electron/electron/releases , Electron supports x64 binaries for Windows. Electron has switched to Chrome 56 since v1.6.x. Is there any reason why VS Code is still very behind in terms of Electron version?
@fearthecowboy
Copy link
Member

👍

@bpasero bpasero added the plan-item VS Code - planned item for upcoming label Mar 24, 2017
@bpasero bpasero added this to the April 2017 milestone Mar 24, 2017
@bpasero
Copy link
Member

bpasero commented Mar 24, 2017 •
edited
Loading

We are in the process of looking into an update. This is independent from shipping VS Code in 64bits on Windows.

@rhyek
Copy link

rhyek commented Mar 26, 2017

@bpasero, I'm interested in an update to Electron as well for a fix to the mixed DPI screens issue that's been annoying me for almost a year now, heh. #6196.

This was referenced Apr 1, 2017
Closed
Merged
@bpasero bpasero mentioned this issue Apr 7, 2017
Closed
@kieferrm kieferrm mentioned this issue Apr 8, 2017
Closed
15 tasks
@bpasero bpasero mentioned this issue Apr 11, 2017
Closed
@bpasero
Copy link
Member

bpasero commented Apr 24, 2017

We will go with Electron 1.6.6 for our April release.

@bpasero bpasero closed this as completed Apr 24, 2017
@bpasero bpasero mentioned this issue Apr 25, 2017
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
plan-item VS Code - planned item for upcoming
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
4 participants
@fearthecowboy @rhyek @bpasero @rongjiecomputer