Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--inspect-brk doesn't open vscode window anymore in vscode 1.94.0 #230495

Closed
SimonSiefke opened this issue Oct 4, 2024 · 3 comments · Fixed by #231913
Closed

--inspect-brk doesn't open vscode window anymore in vscode 1.94.0 #230495

SimonSiefke opened this issue Oct 4, 2024 · 3 comments · Fixed by #231913
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug chrome-devtools Issues related to developer tools confirmed Issue has been confirmed by VS Code Team member ESM Issues caused by our AMD => ESM work insiders-released Patch has been released in VS Code Insiders upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone

Comments

@SimonSiefke
Copy link
Contributor

SimonSiefke commented Oct 4, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.94.0
  • OS Version: Ubuntu 24.04

Steps to Reproduce

  1. Run code --inspect-brk
  2. Connect to the Debugger with Chrome Devtools
  3. In Chrome Devtools, click "Resume"
  4. Notice that no vscode window is not opened anymore in vscode v1.94.0

Expected behaviour

When starting vscode with code --inspect-brk, and continuing script execution in chrome devtools, a vscode window is displayed.

Actual behaviour

When starting vscode with code --inspect-brk, and continuing script execution in chrome devtools, no vscode window is displayed.

Additional information

v1.93.1 seems to be the last version to display the vscode window when launched with --inspect-brk . It seems there might have been change between v1.93.1 and v1.94.0.

@deepak1556
Copy link
Collaborator

Warning: 'remote-debugging-port' is not in the list of known options, but still passed to Electron/Chromium.

I am not sure if we ever added remote-debugging-port to supported switches list, don't see any changes particularly between 1.93 and 1.94 in https://github.com/microsoft/vscode/blob/main/src/vs/platform/environment/common/argv.ts.

As for the original issue, do you see the result when running with code --verbose --remote-debugging-port=0 ?

@SimonSiefke
Copy link
Contributor Author

Thanks. code --verbose --remote-debugging-port=0 did indeed print out the debugging port as expected.

I did some more testing and found an issue to be --inspect=brk which was also enabled in my script.

code --inspect-brk

In VSCode 1.93.1:

  • Start VS Code using code --inspect-brk
  • Connect to the Debugger with Chrome Devtools
  • In Chrome Devtools, click "Resume"
  • A VS Code window opens

In VSCode 1.94.0:

  • Start VS Code using code --inspect-brk
  • Connect to the Debugger with Chrome Devtools
  • In Chrome Devtools, click "Resume"
  • No VS Code window opens

Here is a screencast of the different behaviour:

code-inspect-brk.mp4

In the screencast, the top terminal starts VSCode 1.94.0. After connecting to the Chrome Devtools debugger and resuming script execution, nothing seems to happen.

In the screencast, the bottom terminal starts VSCode 1.93.1. After connecting to the Chrome Devtools debugger and resuming script execution, a VSCode window is created.

It seems due to the window not opening, no remote debugging port was printed out.

I also tested a plain electron app (ESM + Electron 32.1.0) to see if perhaps the problem might be with electron. But there, debugging also worked without an issue and the electron window was created.

@SimonSiefke SimonSiefke changed the title --remote-debugging-port=0 doesn't print debugging port anymore in vscode 1.94.0 --inspect-brk doesn't open vscode window anymore in vscode 1.94.0 Oct 6, 2024
@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member ESM Issues caused by our AMD => ESM work chrome-devtools Issues related to developer tools and removed ESM Issues caused by our AMD => ESM work labels Oct 7, 2024
@deepak1556
Copy link
Collaborator

Seems like the following upstream issue nodejs/node#53681. I will backport the fix to the runtime.

@deepak1556 deepak1556 added this to the October 2024 milestone Oct 7, 2024
@deepak1556 deepak1556 added the upstream-issue-linked This is an upstream issue that has been reported upstream label Oct 7, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 22, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 23, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug chrome-devtools Issues related to developer tools confirmed Issue has been confirmed by VS Code Team member ESM Issues caused by our AMD => ESM work insiders-released Patch has been released in VS Code Insiders upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants