calling executeCommand in onDidEndTerminalShellExecution causes recursion and the pty host to shutdown

[meganrogge]

Testing #226655

Use the vscode-extension-samples/terminal-shell-integration sample with this addition:

	vscode.window.onDidStartTerminalShellExecution(e => {
			e.shellIntegration.executeCommand('echo hi');
		}),
	vscode.window.onDidEndTerminalShellExecution(e => {
			e.shellIntegration.executeCommand('echo bye');
		}),

Create a terminal, run a command, see the pty host shutdown and see recursion in the terminal

[meganrogge]

edit: also reproduces if you only add:

vscode.window.onDidEndTerminalShellExecution(e => {
	e.shellIntegration.executeCommand('echo bye');
}),

[justschen]

I ran into this earlier as well but couldn't figure out what was causing it (my previous issue), but see it in onDidTerminalShellExecuition now as well

[Tyriar]

Not sure how I feel about this one as you're literally asking it to recurse. Maybe we need some throttling?

[Tyriar]

Closing out of scope for now as no one else has hit this