Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: call stacks in the testing view #226684

Closed
2 tasks done
connor4312 opened this issue Aug 26, 2024 · 1 comment
Closed
2 tasks done

Test: call stacks in the testing view #226684

connor4312 opened this issue Aug 26, 2024 · 1 comment
Assignees
Milestone

Comments

@connor4312
Copy link
Member

connor4312 commented Aug 26, 2024

Refs #214488

Complexity: 4
Roles: Developer, Engineering Manager

Create Issue


We now have API to support display call stacks associated with test failure messages. Please:

  1. Read through the API for TestMessageStackFrame and TestMessage.stackTrace and see that it makes sense
  2. Try out the UI. I've adopted it for unit tests in the VS Code repo. Create a failure in a test, or code that a test calls, and see the stack trace view.
    • Note that if the top stack frame is the same location where the failure happened (e.g. an assert) this is automatically hidden since that case just duplicates the code you're already looking at. For best testing of the UI, create a failure that happens a few frames deep.
  3. Verify that its display inside the peek view is correct, as well as the Test Results view when you click on the individual failure.
  4. Verify the various UI works as you would expect it to.
  5. If you would like to play around with the API yourself, you can do so in the selfhost extension or the sample test provider.
@andreamah
Copy link
Contributor

Nice! 🎉

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants