Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test type acquisition and full project intellisense for JS/TS #226653

Closed
2 tasks done
mjbvz opened this issue Aug 26, 2024 · 2 comments
Closed
2 tasks done

Test type acquisition and full project intellisense for JS/TS #226653

mjbvz opened this issue Aug 26, 2024 · 2 comments

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 26, 2024

Test for #182791

Complexity: 4

Create Issue


This iteration we enabled type acquisition on vscode.dev for JS/TS. This means:

  • We can provide intellisense for packages listed in the package.json

  • For JS files, we can provide intellisense for imported files even if they aren't in the package.json, i.e. you can type import $ from 'jquery'; and start getting jQuery IntelliSense

With these two features on, we've also enabled semantic error reporting again

Testing

For this test plan item, try out this new support on https://insiders.vscode.dev and make sure it works as expected. Test in Chrome/edge.

Some basic areas to test

  • Open a small/medium sized TS project from github

    • You get IntelliSense for the module imports
    • Confirm auto imports work
    • You should get semantic/typings errors
    • You can use go to definition and find all references on types from modules
  • Try doing the same but this time opening a folder from your local machine

  • Create a loose js file. Try adding an import for a third party library and confirm you get IntelliSense for it after the typings are installed

Known limitations

  • Safari currently doesn't support this. The nightly safari should but for

  • Currently only tested for small/medium projects. Larger project, such as vscode, will likely work but may take a while to load. We're working on implementing caching to support them better

@alexdima
Copy link
Member

Very cool!

@Yoyokrazy Yoyokrazy removed their assignment Aug 27, 2024
@Yoyokrazy
Copy link
Contributor

works well 👍

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 11, 2024
@github-staff github-staff deleted a comment from Lxx-c Oct 23, 2024
@github-staff github-staff deleted a comment from Lxx-c Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@alexdima @Yoyokrazy @mjbvz and others