Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of cells outside of viewport #223344

Closed
kieferrm opened this issue Jul 23, 2024 · 1 comment · Fixed by #225187
Closed

Handling of cells outside of viewport #223344

kieferrm opened this issue Jul 23, 2024 · 1 comment · Fixed by #225187
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-commands verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

Testing #223152

  1. select two cells
  2. scroll the lower cell (cell 2) out of the viewport
  3. cmd+/
  4. scroll cell 2 partially into the viewport -> only cell 1 has been commented
  5. cmd+/ -> cell 1 has been uncommented, cell 2 has been commented

After step 3 I'd expect both cells to be commented and after step 5 both to be uncommented

@Yoyokrazy Yoyokrazy added bug Issue identified by VS Code Team member as probable bug notebook-commands labels Jul 25, 2024
@Yoyokrazy Yoyokrazy added this to the August 2024 milestone Jul 25, 2024
@Yoyokrazy
Copy link
Contributor

Need to move the toggle comments action off of the editor command. Case is simpler overall since we are not operating on cursors or a specific selection.

Relying on editor.executeCommands() is the limitation, as we don't have editors outside of the viewport. We can construct these edits in a similar way to a LineCommentCommand and simply apply them to the model, allowing us to apply to cells outside of the viewport

@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2024
@joyceerhl joyceerhl added the verified Verification succeeded label Aug 29, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-commands verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants