Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: inline chat sparkle icon #196258

Closed
2 tasks done
aiday-mar opened this issue Oct 23, 2023 · 2 comments
Closed
2 tasks done

Test: inline chat sparkle icon #196258

aiday-mar opened this issue Oct 23, 2023 · 2 comments

Comments

@aiday-mar
Copy link
Contributor

aiday-mar commented Oct 23, 2023

Refs: #1833

Complexity: 2

Create Issue


This iteration, we have added a sparkle icon in the gutter of the editor which on click spawns the inline chat. The icon should appear only when the selection is empty and the cursor line only contains whitespaces or tabs. To test follow the next steps:

  1. Enable the setting inlineChat.showGutterIcon
  2. Open a file and place the cursor on a line so that the selection is empty and the line only contains whitespaces or tabs
  3. Verify that a sparkle icon appears in the gutter at that line
  4. Click on the sparkle icon and verify that inline chat appears at that line
  5. Change the cursor state so that condition 2 is no longer satisfied (you can for example start typing on that line, make a non null selection or place the cursor on a line that is non-empty)
  6. Verify that the sparkle icon is no longer visible in the gutter
  7. Switch documents in the editor, verify that the sparkle icon appears/disappears according to above rules.
@vscodenpa vscodenpa added this to the October 2023 milestone Oct 23, 2023
@ghost ghost assigned anthonykim1 and gregvanl Oct 24, 2023
@aiday-mar
Copy link
Contributor Author

Just discovered the following two bugs:

  1. The inline chat sparkle icon does not appear directly, the cursor selection must be changed for the inline chat sparkle to appear
  2. When changing documents, the inline chat sparkle does not appear as it should even though it is on an empty line

I will be investigating the two issues above.

@aiday-mar
Copy link
Contributor Author

Concerning the issues I mentioned above, the fix is in PR #196412 which should go in soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants