Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read properties of null (reading 'finishShutdown') #194203

Closed
bpasero opened this issue Sep 26, 2023 · 1 comment · Fixed by #194620
Closed

Uncaught TypeError: Cannot read properties of null (reading 'finishShutdown') #194203

bpasero opened this issue Sep 26, 2023 · 1 comment · Fixed by #194620
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders integration-test-failure nodejs NodeJS support issues web Issues related to running VSCode in the web
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 26, 2023

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=233645&view=logs&j=0304f796-6596-5b42-8573-3d5da85bc4a5&t=574b17c2-b1f1-5e41-960d-bfabab7a10d6&l=978

1) git smoke test
       reflects working tree changes:
     Uncaught TypeError: Cannot read properties of null (reading 'finishShutdown')
      at JSStreamSocket.finishShutdown (node:internal/js_stream_socket:160:12)
      at node:internal/js_stream_socket:147:14
      at processTicksAndRejections (node:internal/process/task_queues:81:21)
      at runNextTicks (node:internal/process/task_queues:64:3)
      at processImmediate (node:internal/timers:447:9)

I wonder if this could be a node.js 18 issue?

//cc @deepak1556

@bpasero bpasero added integration-test-failure web Issues related to running VSCode in the web labels Sep 26, 2023
@deepak1556
Copy link
Collaborator

Yes nodejs/node#48519, this is addressed in Node v20 and we have also backported the fix to Electron in #188676. However, we haven't backported the fix to vscode-node but we can.

@bpasero bpasero added the nodejs NodeJS support issues label Sep 27, 2023
@bpasero bpasero closed this as completed Oct 2, 2023
@bpasero bpasero added this to the October 2023 milestone Oct 2, 2023
@bpasero bpasero self-assigned this Oct 2, 2023
@bpasero bpasero reopened this Oct 2, 2023
@bpasero bpasero mentioned this issue Oct 2, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders integration-test-failure nodejs NodeJS support issues web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants