getConfiguration may return malformed results for standard settings

[Colengms]

When an extension calls getConfiguration to retrieve standard VS Code settings, VS Code doesn't appear to validate those settings adhere to schema.

For example, the following code:

    vscode.workspace.getConfiguration("files").get("associations");

if called with the following setting present:

    "files.associations": {
        "badEntry": false
    }

... will return the invalid bool entry.

We can add code to the (C/C++) extension to process and validate standard settings values returned from getConfiguration, But it may be better for VS Code to do this, so all extensions that query standard VS Code settings can benefit and would not have to replicate that validation process.

In the case of the C/C++ Extension, this issue results in a failure in our native process, as our native JSON deserialization code fails to process the unrecognized content, leading to the messages containing that content being discarded as invalid.

Related cpptools bug: microsoft/vscode-cpptools#11375

---

Does this issue occur when all extensions are disabled?: N/A

• VS Code Version:
  Version: 1.82.0-insider (user setup)
  Commit: f7973f3
  Date: 2023-08-28T05:35:52.131Z
  Electron: 25.5.0
  ElectronBuildId: 23084831
  Chromium: 114.0.5735.289
  Node.js: 18.15.0
  V8: 11.4.183.29-electron.0
  OS: Windows_NT x64 10.0.22621

• OS Version: Windows 11

[sandy081]

/duplicate

#125422

[vscodenpa]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!