Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract notebook search model work into its own object #191106

Closed
andreamah opened this issue Aug 23, 2023 · 1 comment
Closed

Abstract notebook search model work into its own object #191106

andreamah opened this issue Aug 23, 2023 · 1 comment
Assignees
@osortega
Labels
polish Cleanup and polish issue search Search widget and operation issues
Milestone
On Deck

Comments

@andreamah
Copy link
Contributor

SearchModel.ts is getting quite long, and certain fields in SearchModel classes are only relevant to notebook search. Consider cleaning this up for a better experience with working with the search model
@andreamah andreamah added polish Cleanup and polish issue search Search widget and operation issues labels Aug 23, 2023
@andreamah andreamah added this to the On Deck milestone Aug 23, 2023
@andreamah andreamah self-assigned this Aug 23, 2023
@andreamah andreamah mentioned this issue Aug 23, 2023
Merged
@rebornix rebornix assigned osortega and unassigned andreamah Dec 11, 2024
@osortega
Copy link
Contributor

searchModel is now significantly smaller than when the issue was open.
Looks like the refactor already happened, closing this

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@osortega osortega

Labels
polish Cleanup and polish issue search Search widget and operation issues
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
2 participants
@andreamah @osortega