Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up ISearchComplete result field #191023

Open
andreamah opened this issue Aug 22, 2023 · 0 comments
Open

clean up ISearchComplete result field #191023

andreamah opened this issue Aug 22, 2023 · 0 comments
Assignees
@osortega
Labels
polish Cleanup and polish issue search Search widget and operation issues
Milestone
Backlog

Comments

@andreamah
Copy link
Contributor

vscode/src/vs/workbench/services/search/common/search.ts

Line 235 in c705233

results: IFileMatch[];

This value is returned by textSearch (

vscode/src/vs/workbench/services/search/common/search.ts

Line 45 in c705233

textSearch(query: ITextQuery, token?: CancellationToken, onProgress?: (result: ISearchProgressItem) => void): Promise<ISearchComplete>;
), but the result is almost never used because onProgress returns results gradually. Consider removing this field from the codebase if it's not needed by anything else.
@andreamah andreamah added polish Cleanup and polish issue search Search widget and operation issues labels Aug 22, 2023
@andreamah andreamah added this to the Backlog milestone Aug 22, 2023
@andreamah andreamah self-assigned this Aug 22, 2023
@andreamah andreamah mentioned this issue Aug 22, 2023
Merged
@rebornix rebornix assigned osortega and unassigned andreamah Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osortega osortega

Labels
polish Cleanup and polish issue search Search widget and operation issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@andreamah @osortega