Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While editing multiline using ctrl + d if a right import suggestion is accepted, it will only effect on the first occurrence's spelling. #188151

Closed
MirwaisAkrami opened this issue Jul 18, 2023 · 4 comments
Assignees
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality

Comments

@MirwaisAkrami
Copy link

Does this issue occur when all extensions are disabled?: Not sure

While editing multiline using ctrl + d if a right import suggestion is accepted, it will only affect on the first occurrence's spelling.

  • VS Code Version: 1.80.1
  • OS Version: Windows 11

Steps to Reproduce:

  1. For example, in a file, I have a variable type called UserService and I want to change it to CustomUserService and there are at least two mentions of it, the type.
  2. I select both of them using ctrl + d and start typing Customuserservice (Notice the small letter u and s in the name).
    After that I ctrl + . it for suggestions and when I accept the suggestion it will update the spelling of the first occurrence only and will leave the subsequent occurrences just like that.
@ArturoDent
Copy link

ArturoDent commented Jul 18, 2023

What command is ctrl + . bound to in the Keyboard Shortcuts editor?

And are the suggestions you are referring to inline suggestions? If so, see #146041

@jrieken jrieken added the info-needed Issue requires more information from poster label Jul 19, 2023
@jrieken
Copy link
Member

jrieken commented Jul 19, 2023

After that I ctrl + . it for suggestions and when

Please clarify if you mean: code actions, suggestions, or ghost text inline suggestions

@MirwaisAkrami
Copy link
Author

Greetings @ArturoDent.
Sorry for the late reply, I was away for some time.
So here is the key bindings configured in my vs code.
vscode-keybindings

And @jrieken, the action is a code suggestion, like you would import an object which you mentioned in your code.

@jrieken jrieken removed their assignment Aug 7, 2023
@jrieken jrieken removed the info-needed Issue requires more information from poster label Aug 7, 2023
@mjbvz mjbvz added editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality labels Aug 8, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Aug 8, 2023
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 8, 2023

For JS/TS there's already a fix all spelling errors code action:

Screenshot 2023-08-08 at 2 51 14 PM

I'm not convinced it's worth supporting multi cursor quick fixes

@mjbvz mjbvz closed this as completed Aug 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-code-actions Editor inplace actions (Ctrl + .) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants