Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: Close Diff On Operation doesn't work #181424

Closed
JHarrisGTI opened this issue May 3, 2023 · 0 comments · Fixed by #184410
Closed

Git: Close Diff On Operation doesn't work #181424

JHarrisGTI opened this issue May 3, 2023 · 0 comments · Fixed by #184410
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@JHarrisGTI
Copy link

Type: Bug

I have the setting: "Git: Close Diff On Operation" enabled. Staging a change will close the diff. Committing a staged change will close the diff. But if I just click the Commit button, the changes will commit but the diff won't close.

Reproduction steps:

  1. Edit & save a file
  2. Click the file in "Source Control" to open a diff
  3. Click Commit

Expected behavior: The "(Working Tree)" tab closes
Actual behavior: It stays open

VS Code version: Code 1.77.3 (Universal) (704ed70, 2023-04-12T09:19:37.325Z)
OS version: Darwin x64 22.4.0
Modes:
Sandboxed: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 3, 3, 2
Memory (System) 16.00GB (0.62GB free)
Process Argv --crash-reporter-id 817d0ddd-3bdc-4e74-993e-15c6f0635a0f
Screen Reader no
VM 0%
Extensions (22)
Extension Author (truncated) Version
tailwind-documentation alf 0.1.6
ng-template Ang 15.2.1
tailwind-docs aus 2.0.0
docs-view bie 0.0.11
vscode-tailwindcss bra 0.9.11
language-postcss cpy 1.1.0
vscode-deno den 3.17.0
vscode-axe-linter deq 4.7.0
nasc-touchbar fel 1.12.0
copilot Git 1.84.51
vscode-test-explorer hbe 2.21.1
tasks-statusbar hed 0.1.0
git-graph mhu 1.30.0
dotenv mik 1.0.1
csharp ms- 1.25.4
test-adapter-converter ms- 0.1.7
vsliveshare ms- 1.0.5864
vscode-yaml red 1.12.2
snyk-vulnerability-scanner sny 1.18.2
code-spell-checker str 2.20.4
vscode-todo-highlight way 1.0.5
pretty-ts-errors yoa 0.4.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
nodejswelcome1:30587005
3biah626:30602489
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
showlangstatbar:30730054
vsccsb:30705552
azdwalk:30721579
pythonms35:30701012
pythonfmttext:30716742
pythonclientmv:30725892
fixshowwlkth:30730052
hidesbindicator:30730055

@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Jun 6, 2023
@lszomoru lszomoru modified the milestones: On Deck, June 2023 Jun 6, 2023
@lszomoru lszomoru added the confirmed Issue has been confirmed by VS Code Team member label Jun 6, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 6, 2023
@connor4312 connor4312 added the verified Verification succeeded label Jun 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants