Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different gutter glyph for unresolved comment threads #174410

Closed
gjsjohnmurray opened this issue Feb 14, 2023 · 3 comments
Closed

Use a different gutter glyph for unresolved comment threads #174410

gjsjohnmurray opened this issue Feb 14, 2023 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@gjsjohnmurray
Copy link
Contributor

Type: Feature Request

The comments API already supports an optional state property of a CommentThread. That property is of type CommentThreadState which is an enum representing Unresolved and Resolved.

When a gutter glyph is added to an editor line in which at least one CommentThread ends, the comment codicon (ea6b) is displayed as a gutter glyph.

As an enhancement I suggest that if any of the threads whose range ends on a given line has its state set to Unresolved then the gutter glyph should be comment-unresolved (ec0a).

Looking ahead, PR #173305 proposes a new CommentVisibility enum for a new optional visibility property of Comment. If this gets merged the gutter glyph should perhaps become comment-draft (ec0e) if any of its threads returns hasDraftComments as true.

VS Code version: Code - Insiders 1.76.0-insider (af4a70d, 2023-02-14T05:22:59.020Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes

@gjsjohnmurray gjsjohnmurray changed the title Use a different gutter glyph for unresolved comments Use a different gutter glyph for unresolved comment threads Feb 14, 2023
@gjsjohnmurray
Copy link
Contributor Author

/assign @alexr00

@gjsjohnmurray
Copy link
Contributor Author

/duplicate of #149162

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 15, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants