You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The comments API already supports an optional state property of a CommentThread. That property is of type CommentThreadState which is an enum representing Unresolved and Resolved.
When a gutter glyph is added to an editor line in which at least one CommentThread ends, the comment codicon (ea6b) is displayed as a gutter glyph.
As an enhancement I suggest that if any of the threads whose range ends on a given line has its state set to Unresolved then the gutter glyph should be comment-unresolved (ec0a).
Looking ahead, PR #173305 proposes a new CommentVisibility enum for a new optional visibility property of Comment. If this gets merged the gutter glyph should perhaps become comment-draft (ec0e) if any of its threads returns hasDraftComments as true.
VS Code version: Code - Insiders 1.76.0-insider (af4a70d, 2023-02-14T05:22:59.020Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes
The text was updated successfully, but these errors were encountered:
gjsjohnmurray
changed the title
Use a different gutter glyph for unresolved comments
Use a different gutter glyph for unresolved comment threads
Feb 14, 2023
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Type: Feature Request
The comments API already supports an optional
state
property of aCommentThread
. That property is of typeCommentThreadState
which is an enum representing Unresolved and Resolved.When a gutter glyph is added to an editor line in which at least one
CommentThread
ends, thecomment
codicon (ea6b) is displayed as a gutter glyph.As an enhancement I suggest that if any of the threads whose range ends on a given line has its
state
set to Unresolved then the gutter glyph should becomment-unresolved
(ec0a).Looking ahead, PR #173305 proposes a new
CommentVisibility
enum for a new optionalvisibility
property ofComment
. If this gets merged the gutter glyph should perhaps becomecomment-draft
(ec0e) if any of its threads returnshasDraftComments
astrue
.VS Code version: Code - Insiders 1.76.0-insider (af4a70d, 2023-02-14T05:22:59.020Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes
The text was updated successfully, but these errors were encountered: