Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline string logging with variablesReference #17333

Closed
roblourens opened this issue Dec 15, 2016 · 5 comments
Closed

Multiline string logging with variablesReference #17333

roblourens opened this issue Dec 15, 2016 · 5 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@roblourens
Copy link
Member

Using OutputEvent with a variablesReference, multiline logs aren't supported anymore.

image

Especially a problem when I need to print a stack from an exception or console.trace()
image

Maybe not straightforward to fix since variables are always 1-line everywhere else?

@roblourens
Copy link
Member Author

I think those \n are going into the console height calculation though -

image

image

@isidorn isidorn added this to the January 2017 milestone Dec 19, 2016
@isidorn
Copy link
Contributor

isidorn commented Dec 29, 2016

I think we fixed this last minute prior to 1.8 release. Anywasy works for me now
We might fix how we hande new line and output events so we should still keep this in mind as a good test case

screen shot 2016-12-29 at 14 54 46

@isidorn isidorn closed this as completed Dec 29, 2016
@roblourens
Copy link
Member Author

In my original example I was using variableReference, but if you try that now, it won't be because I changed it to not use variableReference when logging only text. I still see this if I include an object like in my second comment:

I think those \n are going into the console height calculation though -

image

image

@isidorn
Copy link
Contributor

isidorn commented Jan 4, 2017

Works for me.
My steps:

  1. insiders, mac, node2 debug session stopped
  2. in repl: console.log('a\nb', {a : 1})

screen shot 2017-01-04 at 21 23 42

Please try with latest or give me your exact steps

@isidorn isidorn closed this as completed Jan 4, 2017
@roblourens
Copy link
Member Author

It does work now, maybe it was fixed by the fix for #17404. Thanks

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

3 participants