Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python Env Creation/Deletion in Kernel Picker #172103

Closed
1 of 4 tasks
DonJayamanne opened this issue Jan 24, 2023 · 14 comments
Closed
1 of 4 tasks

Test Python Env Creation/Deletion in Kernel Picker #172103

DonJayamanne opened this issue Jan 24, 2023 · 14 comments

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jan 24, 2023

Refs: microsoft/vscode-jupyter#11904

Complexity: 4

Authors: @DonJayamanne , @rebornix

Create Issue


We have improved the new MRU kernel picker and enabled that for all Insider users. Please test following scenarios for the platforms you are assigned to.

Initial setup

  • Please install the latest pre-release version of Jupyter and Python extensions
  • Install Pyolite extension
  • Optionally install Polyglot Notebook extension
  • Ensure you have Conda or Python installed

Test creation of Virtual Envs or Conda Env

  • Create a new Notebook
  • Run a cell
  • When prompted to select a kernel create a Virtual Env (or Conda Env) from the kernel picker
  • Verify the cell runs to completion after all of the dependencies have been installed
    I.e. ensure you do not have to click Run button again,.

Test deletion of Virtual Envs

  • Delete the previous .venv or .conda environment from the terminal
  • Go into the kernel picker and click on the refresh button in Python Environments kernel source
  • Verify the .venv or .conda environment is removed from the list
    Ensure you do not need to re-load VS Code
@DonJayamanne DonJayamanne added this to the January 2023 milestone Jan 24, 2023
@ghost ghost assigned roblourens and amunger Jan 24, 2023
@amunger
Copy link
Contributor

amunger commented Jan 24, 2023

I'm not seeing the Pyolite extension, is that in preview somewhere?

@roblourens
Copy link
Member

It's called vscode-pyodide

@amunger
Copy link
Contributor

amunger commented Jan 24, 2023

edit - never mind, somehow I got switched back to release Juypyter. Does not repro on pre-release

@DonJayamanne - With vscode-pyodide installed, I don't get prompted to select a kernel when running a new notebook. Pyolite is auto-selected, so I have to disable that extension to hit the test steps correctly

@DonJayamanne
Copy link
Contributor Author

I don't get prompted to select a kernel when running a new notebook. Pyolite is auto-selected, so I have to disable that extension to hit the test steps correctly

@amunger Please could you file a bug in VS Code for this and assign to @rebornix the related bug is #171385

@roblourens
Copy link
Member

This was out in the last release right? What changed since then? Or am I remembering wrong?

@roblourens
Copy link
Member

I did some copyediting on the wiki that is linked to from the kernel picker (I like those links, hadn't seen it yet) https://github.com/microsoft/vscode-jupyter/wiki/Jupyter-Kernels-and-the-Jupyter-Extension/_compare/da77b90724cf4d99f534d6a36a1155b2e0128370...477d4ecbed1f8cad3fed9a7b6544b1ecc3ea269c please review

@amunger amunger removed their assignment Jan 24, 2023
@DonJayamanne
Copy link
Contributor Author

This was out in the last release right? What changed since then? Or am I remembering wrong?

Are you referring to the WIKI or kernel picker env creation/deletion?

@roblourens
Copy link
Member

The kernel picker env creation

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Jan 24, 2023

The kernel picker env creation

Minor changes to detection of delted envs.
Basically Python extension doesn't detect deletion of envs well enough.

I've reviewed the changes to the WIKI and looks good, please could you sugegst the same changes here as well https://github.com/microsoft/vscode-docs/pull/5962/files as that's where I got that content (i.e. it will go into the vscode docs)

@eleanorjboyd
Copy link
Member

working on this TPI and ran into this bug. Adding it here since it seems more related to python create environment and the kernel picker.

@roblourens
Copy link
Member

Will the kernel picker point to the docs page instead of the wiki? Are we duplicating the content?

@roblourens
Copy link
Member

Would you expect it to detect right away when the environment is deleted and clear the selected kernel? Is it worth opening an issue for that? If I delete the .venv and run a cell I get this
image

@roblourens roblourens removed their assignment Jan 24, 2023
@DonJayamanne
Copy link
Contributor Author

Will the kernel picker point to the docs page instead of the wiki? Are we duplicating the content?

Yes, once we ship the relase and docs have been published.

@DonJayamanne
Copy link
Contributor Author

Is it worth opening an issue for that? If I delete the .venv and run a cell I get this

I'll create an issue for that, we should probably just refresh the list of interpreters at that moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants