Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tunnel invocations should connect to running tunnels #171520

Closed
aeschli opened this issue Jan 17, 2023 · 2 comments
Closed

Tunnel invocations should connect to running tunnels #171520

aeschli opened this issue Jan 17, 2023 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality remote-tunnel verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 17, 2023

There should only be one tunnel server running at a time. So when code tunnel is called a second time it should discover the running server and exit again with a success message.

-> Needs a new command to code tunnel stop to stop already running services.

@joaomoreno joaomoreno added the under-discussion Issue is under discussion for relevance, priority, approach label Jan 25, 2023
@joaomoreno joaomoreno changed the title CLI invocations should connect to the running CLI process Tunnel invocations should connect to the running tunnels Jan 25, 2023
@joaomoreno joaomoreno changed the title Tunnel invocations should connect to the running tunnels Tunnel invocations should connect to running tunnels Jan 25, 2023
@connor4312
Copy link
Member

This is implemented now

@connor4312 connor4312 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Mar 17, 2023
@connor4312 connor4312 added this to the March 2023 milestone Mar 21, 2023
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Mar 21, 2023
@connor4312
Copy link
Member

Verification:

  • Grab the latest standalone CLI https://code.visualstudio.com/insiders/
  • Open at least two terminals, and don't have remote tunnel access turned on in VS Code (or have VS Code closed)
  • Run ./code-insiders tunnel --verbose in terminal.
  • Verify starting as new singleton is printed in the terminal and the tunnel starts
  • Run ./code-insiders tunnel --verbose in another terminal
  • Verify it prints "Connected to an existing tunnel process running on this machine." with control instructions after replaying recent logs from the singleton
  • Verify the control commands printed work as expected
  • Have the two tunnels running again. Ctrl+C in the singleton terminal. Verify the previous "client" terminal notices that and starts up the tunnel
  • Verify the commands code tunnel status, code tunnel restart, and code tunnel kill work. These are alternatives to the "interactive" commands clients normally print. status should exit with an error if no tunnel is running.

@joyceerhl joyceerhl added the verified Verification succeeded label Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality remote-tunnel verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants