Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting "Explorer: Incremental Naming" to disabled and dragging a file to duplicate causes VSCode to hang / crash. #165235

Closed
apboon opened this issue Nov 2, 2022 · 0 comments · Fixed by #165253
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@apboon
Copy link

apboon commented Nov 2, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.73.0-insider
  • OS Version: KDE Neon 5.26.2
Version: 1.73.0-insider
Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
Date: 2022-11-01T15:29:25.993Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.15.0-52-generic
Sandboxed: Yes

Steps to Reproduce:

  1. Go to settings (UI).
  2. Search for "duplicate".
  3. Set "Explorer: Incremental Naming" to disabled.
  4. From the file explorer, hold down the [ Control ] key (to copy a file instead of moving) and drag a file to the same directory.

Actual result:

VSCode hangs until I am presented the "This window is not responding" dialg. Clicking [ Reopen ] has the same effect as [ Close ].

Expected result:

I am telling VSCode to duplicate a file, while I have taken away its algorithm to automatically create new file names. Therefore I might expect VSCode to show a dialog with a text input. The text input would contain the file's current name, which I can alter. Confirming the dialog would copy the file using the new name. Or something to this effect.

But maybe that solution is trying to counter a symptom rather than solving the root of the problem. Because how would should VSCode respond when drag-copying multiple files? Maybe the root of the problem is the ability to set "Explorer: Incremental Naming" to disabled in the first place. Maybe VSCode must always have a 'duplicate file naming algorithm' in order to function? Even if it is a simple one. Removing disabled and using the simple algorithm as a bare minimum would surely fix the problem.

Addendum: The description of disabled states the user "will be prompted to override the existing file". So this might be the expected / intended result.

@lramos15 lramos15 added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues file-explorer Explorer widget issues labels Nov 2, 2022
@lramos15 lramos15 added this to the November 2022 milestone Nov 2, 2022
@lramos15 lramos15 added the bug Issue identified by VS Code Team member as probable bug label Nov 2, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 2, 2022
@connor4312 connor4312 added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants