Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal quick fix hover does not reflect changed keybinding #164757

Closed
joyceerhl opened this issue Oct 26, 2022 · 7 comments · Fixed by #164096
Closed

Terminal quick fix hover does not reflect changed keybinding #164757

joyceerhl opened this issue Oct 26, 2022 · 7 comments · Fixed by #164096
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-quick-fix verified Verification succeeded
Milestone
November 2022

Comments

@joyceerhl
Copy link
Collaborator

joyceerhl commented Oct 26, 2022 •
edited
Loading

  1. Run git create PR
  2. ✅ code action appears
  3. Open keyboard shortcuts editor and change the workbench.action.terminal.quickFix keybinding
  4. Hover over existing code action
  5. 🐛 code action tooltip still says Ctrl+. to trigger quick fix
@meganrogge meganrogge added terminal-quick-fix bug Issue identified by VS Code Team member as probable bug labels Oct 27, 2022
@meganrogge meganrogge mentioned this issue Oct 31, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 15, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Nov 30, 2022
@joyceerhl
Copy link
Collaborator Author

There is no hover feedback for the code action now, and additionally running the default keybinding for the workbench.action.terminal.quickFix command results in an error about the command not being found.

Image

@joyceerhl joyceerhl reopened this Nov 30, 2022
@joyceerhl joyceerhl added verification-found Issue verification failed and removed verified Verification succeeded labels Nov 30, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Nov 30, 2022
@meganrogge
Copy link
Contributor

sorry @joyceerhl the command is now: workbench.action.terminal.showQuickFixes

@meganrogge meganrogge removed the verification-found Issue verification failed label Nov 30, 2022
@meganrogge
Copy link
Contributor

we went with this name to align with all commands IE use a verb - show

@joyceerhl
Copy link
Collaborator Author

I no longer see the hover with the keybinding though?

@meganrogge
Copy link
Contributor

that is by design as we're using the action widget

@joyceerhl
Copy link
Collaborator Author

Are the verification steps for this issue just that the keybinding is not reflected anywhere in the UI?

@meganrogge
Copy link
Contributor

Yes and that you can change the keybinding/ it works

@joyceerhl joyceerhl added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-quick-fix verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

add ActionWidgetService microsoft/vscode
3 participants
@meganrogge @joyceerhl @vscodenpa