Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: Support showing entire cell on hover #163580

Closed
mortifia opened this issue Oct 13, 2022 · 4 comments
Closed

Tree: Support showing entire cell on hover #163580

mortifia opened this issue Oct 13, 2022 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality tree-widget Tree widget issues

Comments

@mortifia
Copy link

image
image
image

it's not break the way of reading
is less hard for the eyes

@Tyriar
Copy link
Member

Tyriar commented Oct 13, 2022

Windows explorer does this too, pretty nifty
image

I think I might have reported or commented on a similar issue at some point 🤔

@Tyriar Tyriar assigned lramos15 and unassigned Tyriar Oct 13, 2022
@mortifia
Copy link
Author

you can link this issues ? (you can find in your history ^^)

@lramos15 lramos15 added feature-request Request for new features or functionality tree-widget Tree widget issues workbench-hover Hover issues in the workbench labels Dec 7, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Dec 7, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@joaomoreno joaomoreno changed the title quality of life visual on hover Tree: Support showing entire cell on hover Dec 8, 2022
@joaomoreno joaomoreno assigned joaomoreno and unassigned lramos15 Dec 8, 2022
@joaomoreno joaomoreno removed the workbench-hover Hover issues in the workbench label Dec 8, 2022
@joaomoreno joaomoreno modified the milestones: Backlog Candidates, Backlog Dec 8, 2022
@joaomoreno joaomoreno removed their assignment Dec 14, 2023
@benibenj benibenj self-assigned this Jan 29, 2024
@benibenj benibenj modified the milestones: Backlog, February 2024 Feb 5, 2024
@benibenj
Copy link
Contributor

benibenj commented Feb 19, 2024

After exploring this idea and putting together a prototype, we had discussions about it and ultimately decided against implementing the feature. Here's a quick rundown of our reasoning:

  • We initially hoped to solve this with CSS, but overflow: hidden did not make this possible
  • Implementing this feature would require us to duplicate the element onto the root workbench DOM element and overlay it on the original, ensuring identical styling and forwarding all user interactions (like clicks and context menus) back to the original. That's quite complex and 'hacky'.
  • Feedback suggested it did not feel natural, with the flickering being particularly bothersome.
  • There wasn't much demand or interest for this feature to begin with.

So, we shifted our focus towards adding custom hovers to most elements in lists/trees. This might make it easier to read the label when the item is overflowing and allows us to add more information to the hover in the future.

@benibenj benibenj closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2024
@rzhao271 rzhao271 removed this from the February 2024 milestone Feb 19, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality tree-widget Tree widget issues
Projects
None yet
Development

No branches or pull requests

7 participants