Dedupe identical suggestions

[mrmlnc]

Hello, VS Code team!

/cc @aeschli — because he's God of the CSS service in VS Code
/cc @Tyriar — because I know that he uses the vscode-scss and may regard the proposal as a user
/cc any VS Code team members and users

I am the creator of two very useful (😅) plugins: vscode-less and vscode-scss.

These plugins provide more informative suggestions for Less and Sass symbols (such as Variables, Mixins and Functions) from all files in the workspace (including @import and // <reference...> comments).

And it would be nice if users could disable the standard suggestions for Symbols because they have duplicates.

For example, Variables in Less:

And Functions in Sass:

For users. Please, use GitHub emotions:

👍 - upvote
👎 - downvote

[jrieken]

We should maybe just dedupe identical suggestions

[mrmlnc]

Yes, I thought about it. But this can cause performance degradation for large collection.

[aeschli]

@mrmlnc Your extension could choose to replace the built-in css completions by contributing to a stronger document selector.
Or you play together with the built-in extension and don't make proposals for variables defined locally. I'm happy to take pull requests to improve my proposals. Also feel free to suggest hooks to the css-languageservice that you could use to give your extra proposals.

Adding more configuration option to css to doesn't make things easier.

[mrmlnc]

@aeschli,

My extensions provide completion for all Symbols in:

• Current workspace (used my own parser: less-symbols-parser and scss-symbols-parser)

• Current document (used your parser from vscode-css-languageservice because it works with incomplete or broken code). Only for nested symbols (from selectors) such as:

  .test {
    @a: 1;
    .selector {
      content: | // @a
    }
  }

Hmm, yeah, I don't thought about removing suggestions for the current document. This sounds reasonable.

Now I use parser/mixin.ts and parser/variable.ts to generate suggestions from the current document by position parser/symbols.ts#L28. It seems to me, that this must easily integrate into your service.

However, there are problems:

• What to do with Functions and Mixins? — because my extensions have SignatureHelp and Hover for Function/Mixin reference and variables + parameters. Also implement this feature or remove support for @function from your service 😄?
• Also need to ability return data from your service to use it inside my extension (e.g. Cache) (now I'm not sure)

[mrmlnc]

@aeschli,

Small clarification:

1. Where better to continue communicating: here or in the vscode-css-languageservice repository?
2. If the variable does not have a default value (e.g. FunctionParameter), then display null/empty string or nothing?

[aeschli]

@mrmlnc For pull requests, use vscode-css-languageservice. Bug reports/feature requests better here where historically we manage all css/less/scss related issues.
I'd suggest to show nothing if there is no default value. Also a label 'no default value' would be an option but looks to intrusive to me.

[jrieken]

I am closing this as a dupe of #17068