Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reveal in Explorer View" fails for nested files #156531

Closed
OldStarchy opened this issue Jul 28, 2022 · 2 comments · Fixed by #165272
Closed

"Reveal in Explorer View" fails for nested files #156531

OldStarchy opened this issue Jul 28, 2022 · 2 comments · Fixed by #165272
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@OldStarchy
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.70.0-insider (user setup)
  • Commit: 9cf2fab
  • OS Version: Windows_NT x64 10.0.22000

Steps to Reproduce:

  1. Enable file nesting "explorer.fileNesting.enabled": true
  2. Create two files, foo.js and foo.min.js
  3. With the foo.min.js editor tab open the "Reveal in Explorer View" command
  4. The foo.min.js file is not revealed in the explorer view

Once you manually expand the foo.js nesting to reveal foo.min.js the command will start working, even if you collapse the tree under foo.js again.

It will stop working again if any change to the tree view is made (creating, deleting, or renaming a file) while the nested tree is collapsed.

Maybe related: #155766

@lramos15 lramos15 added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Jul 28, 2022
@lramos15
Copy link
Member

This is most likely caused by the tree being async. It does not know that node exists because it has not been resolved yet. You having the file open is not a guarantee that the file is in the explorer (think outside files).

@kredenac
Copy link

kredenac commented Oct 8, 2022

Nested files option in VS code is great to automatically declutter explorer view, but this bug is extremely annoying.
When you open some file, VS code automatically shows its location in explorer view, so that you can orient yourself and see what are neighboring files.
This prevents that sync from happening, and this slowdown forces the decision to stop using nested files until it's fixed.

@lramos15 lramos15 added this to the November 2022 milestone Nov 2, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 2, 2022
@connor4312 connor4312 added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants