-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New arrow to revert changes in diff editor interferes with setting breakpoints from diff editor #152115
Comments
@Mingpan do you have ideas for this? |
I don't know if there is a way to make both "revert change" and breakpoints work in the same line. But I think a setting to disable "revert change" sounds very reasonable. +1 to it.
I think the right arrow is supposed to indicate "move / copy what's on the left to the right side". I feel like it's a common practice when working with side-by-side views? But changing it could also be reasonable if more people prefer |
I actually prefer the arrow. But a tooltip and a setting to disable that might indeed be helpful. We are open for a PR here ;) |
Happy to add a setting for it :) I also want to fix one miss from myself... #152165 (sorry about that) Tooltip is definately helpful. I will also see if I might be able to do it - it feels like a general improvement needed, which is tracked by #152088 |
Ref to #3130 |
That would be great!
That would be very helpful if there is an easy fix. Thanks a lot! |
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
Have some diff
Notice that on all lines but the first, hovering in the gutter allows you to set a breakpoint. On the first line there is now an arrow, which appears to have come in through Arrows to revert changes in side by side diff editor #151826:
🐛 the arrow doesn't have a tooltip which makes it hard to tell what it's for or where it came from (I figured it out by inspecting the element).
🐛 this makes it impossible to set breakpoints on the first line of a diff from the diff editor, which is something that I use a fair bit. Could we consider having this action show up somewhere else (e.g. in a codelens), or having a setting to disable this action?
Additionally, I'd like to suggest the
discard
codicon. We use this for git reverts, and IMO it's more intuitively related to reverting a change (I was initially a little surprised by what the right arrow button did)The text was updated successfully, but these errors were encountered: