Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that "View Binary Data" is accessible #141442

Closed
weinand opened this issue Jan 25, 2022 · 5 comments
Closed

Make sure that "View Binary Data" is accessible #141442

weinand opened this issue Jan 25, 2022 · 5 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@weinand
Copy link
Contributor

weinand commented Jan 25, 2022

Testing #141347

I'm not sure how accessible the "inline on hover" action "View Binary Data" is:

CleanShot 2022-01-25 at 16 35 15@2x

@Isidon what's your your POV?

It might be necessary to install the "View Binary Data" command as a context menu action on the variable.

@weinand weinand changed the title Make sure that Make sure that "View Binary Data" is accessible Jan 25, 2022
@connor4312
Copy link
Member

It's structured like other inline actions and is tab-accessible. Let me know if there's anything else to do here.

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Jan 25, 2022
@weinand
Copy link
Contributor Author

weinand commented Jan 25, 2022

@isidorn please let us know whether the "inline on hover" action "View Binary Data" is accessible.

@isidorn
Copy link
Contributor

isidorn commented Jan 26, 2022

@weinand yes, all inline actions are accessible. I just tried it out and my biggest concern is regarding the hex view which is not very accessible. For example up/down do not work in the hex value and I think we could use better aria labels.
@lramos15 have you been thinking about the hex view from the accessibility perspective?

@lramos15
Copy link
Member

@isidorn The hex view attempts to do its best to be accessible. Arrow key navigation should work. @connor4312 Just rewrote it in React versus normal vanilla DOM APIs so some things may have been lost.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

5 participants
@weinand @isidorn @connor4312 @lramos15 and others