Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL support for markdown readme preview #139643

Closed
SMSadegh19 opened this issue Dec 22, 2021 · 3 comments · Fixed by #139644
Closed

RTL support for markdown readme preview #139643

SMSadegh19 opened this issue Dec 22, 2021 · 3 comments · Fixed by #139644
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Milestone
January 2022

Comments

@SMSadegh19
Copy link
Contributor

Hi! I want to solve this issue as a good-first-issue. Please help me if you can :)

In Github there was a problem that README and issues don't work for RTL languages. (you can know about this here.)
Then on November 16, 2021, Github announced that we fixed this problem: (announcement link)

Right-to-left languages are now supported natively in Markdown files, issues, pull requests, discussions, and comments.

But vscode does not support it yet.
For example we see this README in github like this:
image

But in vscode, we see the markdown preview like this:
image

Feature or improvement request:
Providing support for correctly previewing RTL languages texts.
@SMSadegh19 SMSadegh19 mentioned this issue Dec 22, 2021
Merged
@SMSadegh19
Copy link
Contributor Author

Hi! Can you help me to solve this issue? (as a good-first-issue)
@mjbvz

I opened a pull request here: #139644

@mjbvz mjbvz added this to the January 2022 milestone Jan 3, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Jan 5, 2022
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Jan 27, 2022
@SMSadegh19
Copy link
Contributor Author

/verified

@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

Successfully merging a pull request may close this issue.

Adding support for RTL languages for readme markdown preview. SMSadegh19/vscode
3 participants
@mjbvz @SMSadegh19 and others