Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawning child processes on Windows open up new terminals #137481

Closed
rzhao271 opened this issue Nov 18, 2021 · 1 comment
Closed

Spawning child processes on Windows open up new terminals #137481

rzhao271 opened this issue Nov 18, 2021 · 1 comment
Assignees
@deepak1556
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron electron-16-update Issues related to electron 16 update upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed verified Verification succeeded windows VS Code on Windows issues
Milestone
November 2021

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Nov 18, 2021 •
edited
Loading

See #137241 (comment)

  1. On Windows, build from the electron-16.x.y branch
  2. Run OSS
  3. 🐛 Some terminals will pop up during the load (such as ripgrep, or types-registry)
  4. After loading, switch between files in the file explorer
  5. 🐛 More terminals pop up from git

Screencap
@rzhao271 rzhao271 added the electron-16-update Issues related to electron 16 update label Nov 18, 2021
@deepak1556 deepak1556 added windows VS Code on Windows issues bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member labels Nov 18, 2021
@deepak1556 deepak1556 mentioned this issue Nov 23, 2021
Merged
5 tasks
@deepak1556 deepak1556 added this to the November 2021 milestone Nov 23, 2021
@deepak1556 deepak1556 added electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed and removed upstream-issue-linked This is an upstream issue that has been reported upstream labels Nov 23, 2021
@deepak1556
Copy link
Collaborator

Fixed with 69c531a

@bpasero bpasero added the verified Verification succeeded label Dec 2, 2021
@deepak1556 deepak1556 mentioned this issue Jan 4, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron electron-16-update Issues related to electron 16 update upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
3 participants
@bpasero @deepak1556 @rzhao271