Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install rpm deps with correct bitness #13616

Closed
Tyriar opened this issue Oct 12, 2016 · 4 comments
Closed

Install rpm deps with correct bitness #13616

Tyriar opened this issue Oct 12, 2016 · 4 comments
Assignees
Labels
debt Code quality issues help wanted Issues identified as good community contribution opportunities install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 12, 2016

#13544 introduces libXss.so.1 as a dependency to the rpm package, this installs both 32-bit and 64-bit packages which is less than ideal. We should include only he necessary one in the build step.

screen shot 2016-10-12 at 9 40 33 am

@Tyriar Tyriar added debt Code quality issues install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux labels Oct 12, 2016
@Tyriar Tyriar added this to the Backlog milestone Oct 12, 2016
@Tyriar Tyriar self-assigned this Oct 12, 2016
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Oct 14, 2016
@polygotdev
Copy link
Contributor

I could help out here. I've have some initial thoughts outlined in this gist...
https://gist.github.com/polygotdev/8110b92e8b2d1ce20998c4bbc4e41c0b

I have done some initial validation with a change to the RPM spec file to include a conditional.
I've also validated package build and installation on the following platforms:

  • CentOS-7-x86_64-DVD-1610-01
  • rhel-server-7.2-x86_64-dvd
  • Fedora-Workstation-Live-i386-24-1.2
  • Fedora-Workstation-Live-x86_64-24-1.2

I can throw in some screenshots as well.

I can do a pull request if this is of value, there is a standard fork/branch with the change incorporated for your review.

https://github.com/polygotdev/vscode/tree/debt_13616_linux_rpm_depends_bitness

Cheers

@Tyriar
Copy link
Member Author

Tyriar commented Oct 30, 2016

Thanks a lot for looking into this @polygotdev, I was thinking doing something like this would be necessary. A PR would be awesome 😃

@polygotdev
Copy link
Contributor

a followup on the insiders build installation, looking good, results at

https://gist.github.com/polygotdev/8610fff8d0c0419c0b22215850517433#file-code-insiders-1-8-0-1478617894-el7-x86_64-rpm-log

@Tyriar
Copy link
Member Author

Tyriar commented Nov 8, 2016

Awesome 😄 I'll close this off, it'll get another test at release time.

To verifier: Please test that the libXss/libXScrnSaver is installed with the correct bitness on both fedora 32-bit and 64-bit.

@Tyriar Tyriar closed this as completed Nov 8, 2016
@rebornix rebornix added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues help wanted Issues identified as good community contribution opportunities install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants