Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple SemanticTokensProvider, [possibly other providers too] #135599

Closed
REYNEP opened this issue Oct 21, 2021 · 3 comments
Closed
Labels
feature-request Request for new features or functionality semantic-tokens Semantic tokens issues

Comments

@REYNEP
Copy link

REYNEP commented Oct 21, 2021

Currently a lot of providers [e.g. DocumentSemanticTokensProvider] supports a single one. if multiple are registered the best matching one is chosen.

So no 2nd extension can add tokens along with 1st extension's tokens.

The Feature

Add support for multiple SemanticTokensProvider, [possibly other providers too].... so that, a extension can add stuffs on top of another.

Some may ask, 'Why?'. Bcz semanticTokens are more like for IntelliSense, and running multiple different IntelliSense is not a good performance Idea.

But, there could be a single running Intellisense & LanguageServer that two different extensions could be using, and both of those could be like adding different kinds of SemanticTokens....

@REYNEP REYNEP changed the title Add support for multiple SemanticTokensProvider, [possibly other providers too].... so that, a extension can add stuffs on top of another Add support for multiple SemanticTokensProvider, [possibly other providers too] Oct 21, 2021
@aeschli aeschli assigned alexdima and unassigned aeschli Oct 22, 2021
@alexdima alexdima added feature-request Request for new features or functionality semantic-tokens Semantic tokens issues labels Oct 26, 2021
@alexdima alexdima removed their assignment Oct 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality semantic-tokens Semantic tokens issues
Projects
None yet
Development

No branches or pull requests

4 participants
@alexdima @aeschli @REYNEP and others