Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminals don't use full width of panel #133967

Closed
jrieken opened this issue Sep 28, 2021 · 2 comments
Closed

Terminals don't use full width of panel #133967

jrieken opened this issue Sep 28, 2021 · 2 comments
Assignees
@meganrogge
Labels
polish Cleanup and polish issue terminal General terminal issues that don't fall under another label
Milestone
Backlog

Comments

@jrieken
Copy link
Member

jrieken commented Sep 28, 2021

Testing #133550

  • have an output channel with scrollbar -> the scrollbar is all the right of its container
  • have a terminal with scrollbar -> there is a gap between the scrollbar and its container
gap perfect alignment
Screen Shot 2021-09-28 at 10 58 02 Screen Shot 2021-09-28 at 10 57 55
@meganrogge meganrogge added polish Cleanup and polish issue terminal General terminal issues that don't fall under another label labels Sep 28, 2021
@meganrogge meganrogge added this to the October 2021 milestone Sep 28, 2021
@Tyriar Tyriar removed their assignment Oct 27, 2021
@Tyriar Tyriar changed the title Terminals don't use full with of panel Terminals don't use full width of panel Oct 27, 2021
@Tyriar Tyriar modified the milestones: October 2021, Backlog Oct 28, 2021
@meganrogge
Copy link
Contributor

Spent awhile investigating this - it was last working properly in VS Code 1.60. Tried reverting terminal.css and TerminalInstance.ts to what they were in version 1.60 and that didn't solve the problem, so I believe a change in xterm.js caused this.

@meganrogge
Copy link
Contributor

Looks fixed to me

Screenshot 2023-11-10 at 10 59 14 AM

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
polish Cleanup and polish issue terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jrieken @Tyriar @meganrogge