Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow also setting the language_info in a notebook #132694

Closed
mjbvz opened this issue Sep 8, 2021 · 3 comments
Closed

Allow also setting the language_info in a notebook #132694

mjbvz opened this issue Sep 8, 2021 · 3 comments
Assignees
@DonJayamanne @mjbvz
Labels
feature-request Request for new features or functionality
Milestone
August 2021 Recovery

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 8, 2021 •
edited
Loading

The current ipynb api only allows setting the kernelspec. We should also allow extensions to set the language_info
@mjbvz mjbvz added this to the August 2021 Recovery milestone Sep 8, 2021
@mjbvz mjbvz added the feature-request Request for new features or functionality label Sep 8, 2021
@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 8, 2021 •
edited
Loading

Fixed by #132298

@mjbvz mjbvz closed this as completed Sep 8, 2021
@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 8, 2021

@davidanthoff @DonJayamanne Can you please verify this new api resolves your issue? It should be in the latest VS Code insiders build

@davidanthoff
Copy link
Contributor

I just updated julia-vscode/julia-vscode#2424 to work with this new API, and it seems to all work! Hurray, much appreciated.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
August 2021 Recovery
Development

No branches or pull requests
3 participants
@davidanthoff @DonJayamanne @mjbvz