Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interactive window doesn't show execution count when collapsed #132064

Open
rchiodo opened this issue Sep 1, 2021 · 5 comments
Open

New interactive window doesn't show execution count when collapsed #132064

rchiodo opened this issue Sep 1, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window regression Something that used to work is now broken
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Sep 1, 2021

Issue Type: Bug

Run some code in the new interactive window.

Old window did this:

image

New window does this:

image

Customer complain here:
microsoft/vscode-jupyter#7369

Additionally this change makes our 'goto cell [n]' not make any sense anymore.

VS Code version: Code 1.59.1 (3866c35, 2021-08-19T11:56:46.957Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.96GB (18.28GB free)
Process Argv --crash-reporter-id dfdd92e0-29d5-4def-b766-bb72737729e6
Screen Reader no
VM 0%
Extensions (19)
Extension Author (truncated) Version
vscode-markdownlint Dav 0.43.2
vscode-eslint dba 2.1.23
xml Dot 2.5.1
prettier-vscode esb 8.1.0
codespaces Git 1.0.4
vscode-pull-request-github Git 0.29.2
csharp ms- 1.23.15
python ms- 2021.8.1159798656
vscode-pylance ms- 2021.8.3
jupyter ms- 2021.8.1236758218
remote-containers ms- 0.194.0
remote-ssh ms- 0.65.7
remote-ssh-edit ms- 0.65.7
remote-wsl ms- 0.58.2
vscode-remote-extensionpack ms- 0.21.0
azure-account ms- 0.9.8
debugger-for-chrome msj 4.13.0
email-viewer Tom 5.0.0
markdown-all-in-one yzh 3.4.0
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
vsccppwtct:30329789
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt2:30360495
bridge0723:30353136
javagetstartedt:30351793
vsdyn321cf:30356811
vscus224:30358039

@DonJayamanne
Copy link
Contributor

I would like to see this in notebooks as well.
Related issue for notebooks #131200

This was also brought up internally by some other notebook users as well (i think its a usability issue).

@zalberts
Copy link

zalberts commented Sep 2, 2021

Additionally - when collapsed, the new icon (6-point star?) does not show any indication if the cell is running code or processing. Previously showed a rotating [*] to show the cell was still running
Previous:
image

New:
image

@simpsus
Copy link

simpsus commented Sep 4, 2021

+1 for @zalberts addition. Very annoying regression in usability. any tips on how to get the old behaviour again appreciated.

@greazer greazer added regression Something that used to work is now broken bug Issue identified by VS Code Team member as probable bug labels Sep 29, 2021
@greazer greazer added this to the October 2021 milestone Sep 29, 2021
@connor4312
Copy link
Member

@zalberts' mentioned issue is captured in #130816

@rebornix rebornix removed the notebook label Oct 21, 2021
@rebornix rebornix modified the milestones: October 2021, On Deck Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug interactive-window regression Something that used to work is now broken
Projects
None yet
Development

No branches or pull requests

8 participants
@rebornix @simpsus @DonJayamanne @connor4312 @greazer @rchiodo @zalberts and others