Gutter color should be consistent with scrollbar for new content

[octref]

For newly added content, color on gutter should be consistent with the one in scrollbar.

[joaomoreno]

Where does that blue come from? AFAIK Code doesn't have those decorations, is that an extension?

[octref]

@joaomoreno It's the git integration on the scrollbar I believe. I tried running vscode with --disable-extensions it's still there:

Same for deleted lines (red left & blue right):

[joaomoreno]

Oh yeah, sorry man, totally spaced out there.

This was a purposeful decision. We decided to go with blue for the scrollbar colour, independently of the type of code change, to reduce traffic light syndrome. Not to mention that the decorations would be confused for errors and warnings...

If you feel passionate about it, we can make it into a setting.

[octref]

@bgashler1 Any thoughts?

Possibly related: #8017

[octref]

These are incomingBaseColor from here: https://github.com/Microsoft/vscode/blob/master/src/vs/platform/theme/common/colorRegistry.ts#L282
and editorGutterAddedBackground from here:
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/scm/electron-browser/dirtydiffDecorator.ts#L711-L715

@alexandrudima Can we make them consistent, or is this as-designed?
Should I try to submit a PR against these two files or each of the included themes?

[alexdima]

@octref I did not define those colors. fyi they are configurable AFAIK and @aeschli changed them to be green<->green, blue<->blue and red<->red both in the line decorations and in the overview ruler and the feedback was overwhelmingly negative.

[octref]

They are indeed configurable through themes.

@aeschli changed them to be green<->green, blue<->blue and red<->red both in the line decorations and in the overview ruler and the feedback was overwhelmingly negative.

I guess that's how dark plus should be colored then.
My theme (Nord) is consistent so I don't mind it.