Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Inline Value Debug View #127751

Closed
hediet opened this issue Jul 1, 2021 · 4 comments
Closed

Improve Inline Value Debug View #127751

hediet opened this issue Jul 1, 2021 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) under-discussion Issue is under discussion for relevance, priority, approach

Comments

@hediet
Copy link
Member

hediet commented Jul 1, 2021

These rendered inline values are not really helpful.
It would be nice if the parameter values were shown (in particular modelLineNumber).

image

@isidorn
Copy link
Contributor

isidorn commented Jul 1, 2021

I agree this could be improved but I think this will be tackled via microsoft/TypeScript#43449 once Typescript is able to provide exact inline values. Then we will not use a limited regex heuristic that we have on the vscode side

@weinand probably knows more on the timing on the TS side

For reference inline values on the vscode side are computed here https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts#L593

We should probably close this as a duplicate.

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Jul 1, 2021
@weinand weinand self-assigned this Jul 1, 2021
@weinand
Copy link
Contributor

weinand commented Jul 1, 2021

Yes, we will need microsoft/TypeScript#43449 before we can fine tune what gets shown as inline values. You might want to add a comment there...

@weinand weinand closed this as completed Jul 1, 2021
@weinand weinand added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 1, 2021
@hediet
Copy link
Member Author

hediet commented Jul 1, 2021

Thanks!

Quick question: Does this middle of line inline values or are they always rendered at the end of the line (like they currently are)?

For parameter values, I think it makes a lot of sense to render numbers/booleans in the middle of the line (potentially with injected text 😉)

@weinand
Copy link
Contributor

weinand commented Jul 1, 2021

Showing inline values at the end of a line is an implementation detail of VS Code. The extension API for inline values does not stipulate that. From the API VS Code knows the source range of the variable/parameter, so we could easily show the value next to the parameter.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants