Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect links in file vscode.d.ts (API reference) #123772

Closed
rwnkl opened this issue May 13, 2021 · 4 comments · Fixed by #124203
Closed

Incorrect links in file vscode.d.ts (API reference) #123772

rwnkl opened this issue May 13, 2021 · 4 comments · Fixed by #124203
Assignees
@mjbvz
Labels
debt Code quality issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Milestone
May 2021

Comments

@rwnkl
Copy link

rwnkl commented May 13, 2021

  • VS Code Version: 1.56.1
  • OS Version: Windows 10 Prof 64 Bit

Steps to Reproduce:

  1. change CustomDocumentProvider to CustomEditorProvider

    • line 7747
    • line 7786

  2. interface TaskProvider
    line 6697: create a md link from #tasks.registerTaskProvider

Does this issue occur when all extensions are disabled?: Yes/No
@mjbvz mjbvz added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels May 13, 2021
@rambabugovind
Copy link

Hi, I would like to look into this issue. Could I be assigned ?

@5150og
Copy link

5150og commented May 17, 2021

I'm new to this, but I'm eager to learn!

@mzainuddin51
Copy link
Contributor

Hello, can I work on this issue ?

@mjbvz
Copy link
Collaborator

mjbvz commented May 19, 2021

This is a very small change so please just submit a PR

@mzainuddin51 mzainuddin51 mentioned this issue May 19, 2021
Merged
@mjbvz mjbvz added this to the May 2021 milestone May 21, 2021
@mjbvz mjbvz added debt Code quality issues and removed unreleased Patch has not yet been released in VS Code Insiders labels May 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
debt Code quality issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Projects
None yet
Milestone
May 2021
Development

Successfully merging a pull request may close this issue.

fix incorrect links for issue #123772 mzainuddin51/vscode
6 participants
@mjbvz @rambabugovind @rwnkl @mzainuddin51 @5150og and others