Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent diff result of cell movement #122150

Closed
rebornix opened this issue Apr 26, 2021 · 1 comment
Closed

Inconsistent diff result of cell movement #122150

rebornix opened this issue Apr 26, 2021 · 1 comment
Assignees
@rebornix
Labels
insiders-released Patch has been released in VS Code Insiders notebook-diff verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2021

Comments

@rebornix
Copy link
Member

As shown in below screenshot, if we swap the 2nd/3rd cells, and swap 5th/6h cells in the left notebook, we will get the notebook on the right side editor

image

However if we compare these two notebooks in the diff editor, the "move" operation is not consistent

image

The first "move" is interpreted as "delete then insert" while the second one is "insert then delete".
@rebornix rebornix added this to the April 2021 milestone Apr 26, 2021
@kieferrm kieferrm mentioned this issue Apr 26, 2021
Closed
75 tasks
@rebornix rebornix self-assigned this Apr 26, 2021
@rebornix
Copy link
Member Author

image

@rebornix rebornix added the verification-needed Verification of issue is requested label Apr 27, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
insiders-released Patch has been released in VS Code Insiders notebook-diff verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
3 participants
@rebornix @rzhao271 and others