Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging tabs should show an insertion target, not a replacement target #118419

Closed
joachim-n opened this issue Mar 8, 2021 · 3 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) workbench-tabs VS Code editor tab issues

Comments

@joachim-n
Copy link

  • VS Code Version: 1.54
  • OS Version: MacOS 10.15.7

Steps to Reproduce:

  1. Drag an editor tab to insert it between two other tabs.
  2. The other tabs highlight when the mouse passes over it, as if to demonstrate that the tab I am dragging is going to go ONTO or REPLACE the highlighted tab. But that's not what will happen. The dragged tab will be INSERTED between two other tabs. Highlighting a tab like this is ambiguous: I can't tell whether the dragged tab will go to the left or the right of the highlighted tab when I drop it.

Instead, either an insertion mark should be shown to indicate the position where the dragged tab will go if I drop it, or the tabs should move to show the space where the dragged tab will go (as Firefox and Chrome currently behave).

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Mar 8, 2021

@bpasero bpasero added the workbench-tabs VS Code editor tab issues label Mar 8, 2021
@bpasero
Copy link
Member

bpasero commented Mar 8, 2021

/duplicate #8544

@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

3 participants
@joachim-n @bpasero and others