Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular syntax profile from emmet doesn't work after 1.5.0 update #11799

Closed
AldoMX opened this issue Sep 9, 2016 · 4 comments
Closed

angular syntax profile from emmet doesn't work after 1.5.0 update #11799

AldoMX opened this issue Sep 9, 2016 · 4 comments

Comments

@AldoMX
Copy link
Contributor

AldoMX commented Sep 9, 2016

  • VSCode Version: 1.5.1
  • OS Version: Microsoft Windows [Version 6.1.7601]

Steps to Reproduce:

1 - Set the angular syntax profile in your settings.json, example:

{
    "emmet.syntaxProfiles": {
        "html": "angular"
    }
}

2 - Create a new HTML File

3 - Try to expand an emmet expression, example:

ul>li*5

3b - Or an angular-specific emmet expression, example:

md-content[layout="column"]>md-button{Save}

I noticed that both versions of VS Code: 1.4.0 and 1.5.1 have the same version of emmet installed (1.3.1).

@mrmlnc
Copy link
Contributor

mrmlnc commented Sep 9, 2016

Hello, @AldoMX,

What do you mean by angular profile? By default Emmet not have angular profile.

@ramya-rao-a ramya-rao-a added the info-needed Issue requires more information from poster label Sep 9, 2016
@AldoMX
Copy link
Contributor Author

AldoMX commented Sep 9, 2016

I think I'm getting crazy...

Apparently the angular profile never existed although I was pretty confident that it did, and I took it for granted since I had found out undocumented emmet's features in the past, such as the |slim or |jade filters.

Anyway, the "issue" is real, but it will probably be a WONTFIX:

In VS Code <= 1.4.0, when you press tab and the emmet profile is invalid, ex.:

{
    "emmet.syntaxProfiles": {
        "html": "gibberish"
    }
}

It triggers emmet anyway, which results in emmet expanding invalid expressions (but valid in the context of Angular) such as

ng-app

into

<ng-app></ng-app>

Which led me to believe the non-existent angular profile actually existed.

Basically, VS Code 1.5.0 fixed the bug, broke my workflow, and made me learn that I was probably asleep when I found out about the angular profile...

Please accept an apology and the following XKCD comic for this bogus bug report.

@mrmlnc
Copy link
Contributor

mrmlnc commented Sep 9, 2016

Don't worry. Now syntaxProfiles used as fileAssociations, but for Emmet: left side — language Id, right side — Emmet mode or your own syntax profile. You can find the basic modes of Emmet in #9500 (comment).

Please, close this issue if it is resolved.

@ramya-rao-a ramya-rao-a removed the info-needed Issue requires more information from poster label Sep 11, 2016
@ramya-rao-a
Copy link
Contributor

@AldoMX Emmet abbreviations should work for you in html files without setting any syntax profiles.
Closing this issue as resolved.
Love the xkcd comic :)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants