-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a warning when an externalConsole attribute used in Launch #11209
Comments
August to investigate |
Fixed by 74a526a in https://github.com/Microsoft/vscode-node-debug |
Actually that is not a good fix, since we still want to show the message that the attribute is deprecated. |
I would do the 'pattern' and 'custom error' message trick. JSON schema doesn't have a way to disallow a specific property. You can enforce that only the specified properties are allowed, but the error message will be generic. |
Work on our side is done, for this to fully work we are waiting for #11305 |
@isidorn It seems the warning is appearing on the value instead of the attribute. It looks like as if the value is not supported. But in this case attribute itself is not valid. So does it makes sense to show squiggle on attribute or complete attribute-value? |
Testing #11091
Steps to Reproduce:
Since
externalConsole
attribute is deprecated, it would make sense to show a warning in the launches when this attribute is used.The text was updated successfully, but these errors were encountered: