Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned tabs on dragged tabs #110935

Closed
Brixbrax opened this issue Nov 19, 2020 · 4 comments
Closed

Pinned tabs on dragged tabs #110935

Brixbrax opened this issue Nov 19, 2020 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster workbench-tabs VS Code editor tab issues

Comments

@Brixbrax
Copy link

If I drag a normal tab to the place of a pinned tab, the dragged tab gets pinned too (while the original tab keeps its pinned state but moves right).

@bpasero
Copy link
Member

bpasero commented Nov 19, 2020

yeah, works as designed.

@bpasero bpasero added the info-needed Issue requires more information from poster label Nov 19, 2020
@Brixbrax
Copy link
Author

Thank you for your answer.
To be more precise e.g. I have 4 unpinned, normal tabs:
tab1, tab2, tab3, tab4
I set tab1 pinned. Great. But if I drag tab2 to the first place, tab2 changes to pinned, too. Tab1 moves right and keeps the pinned state, so I have two pinned tabs now. Then I drag tab3 to the first place as well as tab4. I will have four pinned tabs finally but I want only one to be pinned.

@bpasero bpasero added the workbench-tabs VS Code editor tab issues label Nov 19, 2020
@bpasero
Copy link
Member

bpasero commented Nov 19, 2020

Yeah I understand, but that is intentional. I think the only way to fix this is to allow for dropping the tab precisely before or after the pinned tab.

/duplicate #8544

@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @Brixbrax and others